Prevent the invariant prefix optimization from defying the walk behavior #57
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
force-pushed
the
fix/invariant-prefix-symlink
branch
from
08fd2c3 to
59b7b0a
Compare
|
I believe this is obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic for calculating the anchor can cause globs that have an invariant that cross a symlink to traverse that symlink even if the walk behaviour is set to ignore them. To solve this, we need to check if any of the parent files are symlinks and use the most-recently-found symlink. I left a todo in, because if anchor were to know about the walk behaviour then we could improve performance a little, but I want to leave that decision up to you.
Cheers!
Alex